Larian Studios Forums Divinity - Original Sin Divinity Original Sin - Mods Problem with Item teleport to trigger

Hi. In my mod i have a skill that the player can use to click on an NPC and then get information about how that character has moved, the code looks like this:

IF
CharacterUsedSkillOnTarget(CHARACTER_Player1,CHARACTER_Manduk, "Target_Tracking", "Target")
THEN
ItemTeleportToTrigger(ITEM_Manduk_Trace_To_Bury_1,TRIGGER_Manduk_To_Bury_1);
ItemTeleportToTrigger(ITEM_Manduk_Trace_To_Bury_2,TRIGGER_Manduk_To_Bury_2);
etc etc for each
In game:



So the white glowing things are traces of the movement from the NPC and they move to the trigges when the player uses the skill on an NPC, this works fine. I also have a skill that's supposed to remove the white trace things but it's not working:

IF
CharacterUsedSkill(CHARACTER_Player1, "Remove_Tracks", "Earth")
THEN
ItemTeleportToTrigger(ITEM_Manduk_Trace_To_Bury_1,TRIGGER_Trace_Collector);
ItemTeleportToTrigger(ITEM_Manduk_Trace_To_Bury_2,TRIGGER_Trace_Collector);
etc etc...


Now this code works in so far that if i use the function ItemMoveToTrigger instead of ItemTeleportToTrigger the white things move nicely in the direction of the Trace Collector trigger. I can't redo this however, so it only works once and after that they're stuck. ItemTeleportToTrigger doesn't work at all.

Something you can try is setting the items off stage or changing their visibility instead of trying to move them away (using item scripts). This could also make placing and using your tracks way easier. They wouldn't have to be global, you don't need a trigger/item pair with a unique name for each set, and you can show them and make them disappear with a single global event.

it sounds like a great idea but after looking a bit at item scripts and your thread on the subject i'm unsure on how to write the code. There would have to an action that can change an object from visible to invisible and there would have to be a link between CharacterUsedSkillOnTarget in story and the event in the item script. Something like:


INIT
ITEM:__Me

EVENTS

EVENT ChangeVisibility
ON
Event somehow triggered by CharacterUsedSkillOnTarget
ACTIONS
ChangeVisibility(_Me, 0)

This seems doable.

I have a charscript which switches events based on a timer started in Osiris. The call is there for events as well.

So you could write the script in Osiris for Characterusedskillontarget, have that trip an event which the charscript will react to.

The charscript call for visibility is "SetVisible".

This is my script for making my characters walk away after the timer runs.


So yours would be something like
Story editor:


ItemScript

Welp that worked, looks pretty cool as well. Thanks guys.

Another detail that might make your life easier is using an EXTERN variable.

Using Extern will allow you to change by which trigger it is affected by when giving the track its scripts. So each characters tracks can be activated independently.

that was actually exactly what i started thinking about when i implemented the item scripts. Not sure how the code you posted would work in practice. What would the story script look like?

Here is how I would do it:

Story Scripts
INIT


KB


The tracks would have the same scripts from what I provided above.
However when placing the track change the extern variable (its the extra box on the right side when adding scripts) to what event you want the track to trigger on. In this case: ShowMandukTracks and ShowBobTracks.
Note: Do NOT change the script code, that's what the extern is for.

hmm i must say i'm a bit confused by the code.


INIT
ITEM:__Me
EXTERN STRING:%trigger="ShowTracks"

Here the %variable is set to "ShowTracks", which means that if the code below is run:


IF
CharacterUsedSkillOnTarget(_,CHARACTER_Bob, "Target_Tracking", _)
THEN
GlobalSetEvent("ShowTracks");

then all items with the item script you posted will be made visible. I'm not sure if this is what is intended though so i must be missing something.

The tl;dr version is the "ShowTracks" simply populates the field %trigger with a string by default. In this case ShowTracks. You could just leave it blank as "". You need the two quotes to identify it as a string.

Your conditional statement shouldn't use "ShowTracks" anymore but "ShowYOURCHARACTERNAMETracks". For each character.

Long version:

I believe the intent was that you set in the sidebar each characters appropriate globalevent for showing tracks. So in the portion of the script that says EXTERN STRING:%trigger="ShowTracks". %trigger is the variable you set in the sidebar. Which should match the characters name.

ShowBobTracks is the one Zoltan picked.

So your story editor should have separate conditionals for each character. The globalevent "ShowTracks" wouldn't show all characters, it would show none. Since the script is looking for the specific string you put in the sidebar. Unless you keep the conditional for "ShowTracks". I'd probably get rid of it and just use them all individually.

When you use EXTERN STRING:%trigger="ShowTracks" you can replace "ShowTracks with "ShowBobTracks" the "ShowTracks" part is what the script will check for. If you keep it the same and don't remove your conditional for "ShowTracks" then it will always show all characters tracks.



^That is what the script will be if you change it in the sidebar. You do it on the right side pane during the process of adding the script. Not afterward.

This is where:

ah ok i didn't get that you were supposed to give %trigger a string in the sidebar. Now it works, thanks.