I've found the best value to crafting weapons is:
a) You're broke and near a forge but not a store (self-defense)
b) You're broke, near a forge and a store (quick source of store cash)
Both conditions are more apt to occur in the earlier parts of the game, imo.
