I don't mind weapon skills. It's a way to differentiate different types of weapon. With Spear you can "Rush" i.e. charge forward with the spear. Two-handed sword could for example have cleave, hit X enemies in front of you with normal attack, two-handed hammer could have a "stunning blow" etc. Adding it as a skill to the weapon abilities despite it being weapon class feature makes it easier to read.