I think it be awesome even if they only had one male and female voice like mass effect or two male and two female like dragon age inquisition to save money a voice just makes your character feel so much more alive
For me it depends a
lot on the VA, and how they choose or are told to do the voice. Worked well in DOS, was okay in DA2/I, but found FO4 and Mass Effect too jarring (both were way too shouty; I think even more jarring once I realised Jennifer Hale had a much broader range which included non-shouty voices, such as the female half of Lutece in Bioshock). Or the Divinity II approach where there wasn't PC-voiced dialogue but my character would comment randomly on various places and events ("ooh, shiny!")
I think the first D:OS isn't really a fair comparison, though, because that game wasn't as focused on the idea of custom characters. You were two source hunters no matter what, your fate was determined for you before you created your character, you just created the look and skills basically. Same for FO4, no matter how you wanted to play it, you were playing a very specific character. And those sorts of RPGs, a voiced protagonist works! It makes sense because you aren't using your imagination to determine who that character you control is, it's not a character you created, it's one defined for you.
I think D:OS2 mostly nailed it in that your thoughts were mostly conveyed by the narrator during dialogue, because you could be Ifan or Fane, but you could also be a custom character with a personality defined in the players mind, not so much by Larian. Now I know D:OS2 had the occasional bit of reactive dialogue, as you mentioned (the ooo shiny bit), but even that was a bit jarring to me because it was so outside of what I expected. But those were infrequent enough that it was easy to ignore or forget. But when it did occur, man it really took me and my friend out of the moment because it totally conflicted with what we envisioned those characters to sound like.
