@Sordak
It applies to on-hit effects as well, though. Using that system, how would a Paladin choose to apply Divine Smite to a crit? How would a Battle Master Fighter apply Precision Attack to a miss?
Hence why I recommend introducing parameters to streamline the process, making it more fluid for everyone. You could still opt to use pop-ups, it wouldn't be the default. This would be an improvement for everyone.
