My main problem with this is that this is a terrible division that locks your character into a specific group based on deity worship (lore-wise anyway). What about surface drow who just mind their own business? What about Underdark drow not from drow cities? What about Vhaeraun worshippers? Etc.
If anything, I'd split high elves into sun and moon since those are actually different subraces, just not in 5e mechanics. But they differ in appearance and culture.
