Moon and Sun elves definitely seem like they should be different subraces. Not only are they fairly distinct in appearance, but culturally as well. To the point that they have come to blows over their differences on more than one occasion.
Wood/Green Elves is a more subtle distinction since they are very similar ethnically, to the point that even many elves don't even distinguish the two groups-it's more of a cultural thing. Still a better basis for distinct subraces than the Seldarine/Lolthsworn thing, IMO.
