It depends on the general game mechanics. If magic items are RARE and powerful then it brings the excitement of discovery but if the game has lots of trash tear magic items in every corner then it will be just a busywork that no one will appreciate. Right now the game is trending towards lots of magic trash route. For instance, if you can get a magic item only by completing some quest and no more than a couple at a time, then identifying separately would make sense.
But on top of not making much sense to me, it could be reamly frustratong if hidden properties were unlocked by the will of a dice. I usually like better in games if, in exemple a specific class can unlock special properties with a weapon. Which is basically what weapons attack are doing with proficiencies 🙂
For this purpose you can just code it to always max roll a D20, then add Arcana proficiencies, and set the DC on anything magic but fairly run-of-the-mill like magic arrows, weapons & armor +1 etc to 22. Anything rarer and more special then up the DC to 25+...
