I'm not sure I ever understood why people hated a companion that was hostile, dismissive, and deeply cynical.
just a bit of rephrasing to make it clearer

Seriously though, first impressions are important. I still remember having to roll a series of ridiculously hard skill checks just for her to state the obvious "I'm a cleric of Sharr.". And if you fail a single one, the "bonus content" you get is "eff off, don't talk to me", so I simply stopped trying to talk to her. I don't care that she has a 'good' reason to be snarky, I care that she's snarky.
I still think that Larian doesn't know how to make characters without making them cynical and sarcastic. I think it's just baked into who they are. They're trying though, having SH say a simple, "hey, thanks for saving me, no really, thanks". was quite a nice change compared to her earlier nastiness.