As others said here, I have a bit of an issue with the last LAST scene with Astarion - the one after he runs away from the sun, when you’re talking to him about your next adventure and all that.
THAT little monologue came across as childish for me. I mean, a morally grey and acid character who (in my play, got a redemption arc), just ends with a rather vanilla monologue about “we’re gonna have a lot of fun” was underwhelming and ooc. I do like the option you have to suggest you’ll be looking for a way to allow him being in the sun - it implies you’ll continue your journey, and that feels nice.
But I wish the dialogue there ended in a different tone. Perhaps tav mentioning you’ve defied the death gods and killed a devil (if you did), and defeated an elder brain overpowered by netherese magic, so you’d have to assume there’s a chance of making a vampire spawn be able to walk in the sun. Something a bit more poignant and a “witty” banter just to end the last few sentences. Something that kept Astarion’s personality more in character - even when he’s become a little “good”.
Now, for the other complaints about his ending, I disagree with people saying his ending is as bad as Karlach’s. It’s not. Not by a mile. Also, his entire questline is much richer, so you get to ‘enjoy the ride’ while you’re at it. And, if you chose the “good” ending, his redemption arch feels a bit sad but very rewarding. He himself says so, and it’s believable. I see no problems there.
Him running from the sun, though… I agree that, if you’re romancing him, it’s very, very strange that you wouldn’t go after him. Just goes against logic. That could’ve been done better.
BUT, if you do go after him, Karlach’s ending is affected too. There’s a big timing issue here. If you care for both of these characters, it creates a logistical problem right there. Maybe they could make Karlach’s ending before the sun affects him? That could solve that problem.
For me, personally this is going to become a huge issue, since I now play as (avatar) Karlach AND romance Astarion. I’m just waiting to see how it ends for them both as a couple, since Astarion runs away before Karlach has her ending - I’m expecting their ending to be the most horrible sad and unfulfilling of all origins combinations because of that… *sigh* lol