Would be nice.
DOS2 had some interesting and convenient crafting recipes. Like turning metal fragments into lockpicks or nails into upgrades to apply to boots to prevent slipping.
BG3's "Crafting" was more annoying. Like "Gather 18 billion of this incredibly rare ingredient that only 2 actually exist in the game unless you vendor exploit, then you can craft ONE singular mediocre potion"
I remember hearing rumours that all the Iron and Silver ingots you find all over was supposed to become part of a crafting system too, but it was eventually scrapped... I wonder how it would have turned out?
But yeah, crafting systems can be interesting if done well.
They can offer different scope. From simply altering existing items to tune them to your liking (For example, putting one of a selection of enhancements on an item, or adjusting one of its stats), to outright crafting new items (Be it creating unique things from rare recipes, to utilising existing items to allow you to copy/remake certain effects onto different item types (I.e. Maybe you want Returning Pike's returning feature, but on a weapon other than a Pike))
Not to mention, consumable crafting. Potions, Scrolls, Bombs, Traps, Poisons, Weapon Oils, Elixirs etc. You can provide a lot of options with such things (Also, it can be interesting for builds if you had feats and item effects that played into some of these. Have a sneaky thief reverse pickpocket Bombs and Poisons into people's inventories to harm them without being noticed. Have bonuses for attacking using weapon oils. Grant bonuses to using Scrolls and Traps. Let someone chug a ton of potions for few action points etc)
Heck, if we have something like a central hub place (I.e. Camp but like, one singular location that is somewhere we return to repeatedly over the campaign (Like the Ship from DOS2)) you can also craft upgrades and features for said place. Furniture and decorations. Additional facilities. Improvement to facilities. With enough scope, you could get people spending thousands of hours just decorating their hub.
It just depends on how much time gets put into the system, how much scope it has and how available crafting materials end up being.
