Larian Studios Forums Divinity: Original Sin 2 - The Modding Dungeon Divinity - Original Sin 2 - Modding Scripting corpse cleanup script

Thanks LL.

I will take your recommendation, and read up on this.

I just finished spending a lot of time building out some quests that included a specific gold amount to return the quest giver and thanks to you. I got that all working.

I now understand how that works intimately, thanks again to your teaching ability!

Anyway back to corpse removal. Its a little dry...

Hopefully, I can have some POC working soon to share.

Its a nice deign feature. It looks clunky haveing corpse's everywhere. But during balance testing you can live with it fer now.

No worries Detect. Keep at it and I'm sure scripting will start to make more sense. And feel free to ask questions, of course.

spending some time on this , getting an error:

auto-define Osiris"DB_MonkWorks_SpawnedEnemies"(): Failed: type of parameter 1 unknown

That errors means the first parameter's type for that database hasn't been defined anywhere.

Here's an example of the first parameter's type not being defined (and the value isn't defined either):

Here you can see the type for _Enemy is defined, while _Level is an unknown value and type.

This:

Or this:

Will compile correctly.

That's the general idea of that kind of error. Not sure what's causing the error in your code specifically, since you didn't post the script context of the error.

You nailed it. Needed to define it. Thanks, testing onward

PROC
MonkWorks_System_Cleanup()
AND
DB_MonkWorks_SpawnedEnemies(_Type, _Enemy) <<<<<error
THEN
SetOnStage(_Enemy, 0);
NOT DB_MonkWorks_SpawnedEnemies(_Type, _Enemy);

PROC
MonkWorks_System_Cleanup()
AND
NOT DB_MonkWorks_SpawnedEnemies(_, _) <<<<<error
THEN
NOT DB_MonkWorks_CleanupRunning(1);

Not sure... type, enemy not defined

It's not clear to the compiler whether the contents of your database are items, characters, triggers, or general GUIDSTRINGs.

As LaughingLeader said above, you'll have to explicitly state whether those are (CHARACTERGUID), (STRINGS), etc...

Right. Make sure the _Enemy column is defined somewhere. The easiest way to do this for a dynamically-created database (one that's added to when needed, rather than being declared in the INIT section) is to use a procedure, as this will set up the correct types with the compiler:

Just using
PROC
MonkWorks_System_Cleanup()
AND
DB_MonkWorks_SpawnedEnemies((STRING)_Type, (CHARACTERGUID)_Enemy)
THEN
SetOnStage(_Enemy, 0);
NOT DB_MonkWorks_SpawnedEnemies(_Type, _Enemy);

should work too, though. You may need to cast some variables to CHARACTERGUIDs where they were GUIDSTRINGS before, but you'd have to do that either way.

Thanks guys. I am like a blind person here, fumbling through. I really should not be pretending I know stuff because I don't. I have many years working on the fringe of software development so I understand a lot about computer languages as a generalist, master of none, knowledge of many. So please forgive me. I am reaching out for help because I don't have the skills to do this, its not like I am reaching out as a scripter trying to get peer support. I have been very lucky that LL provided his script to mess around with. I can continue the development life-cycle of the script and maybe get it tested , again sharing with all who need this in the community.

I may have already said this type of script in previous /similar games was already there. We didn't need to develop the script. All we had to do was call it from OnEnter. Even had a timer type feature. Clean up the level every 30 sec or 30mins. But I do remember it being a very large script more then 200 lines IIRC.

ok back to my thickness-

"As LaughingLeader said above, you'll have to explicitly state whether those are (CHARACTERGUID), (STRINGS), etc..."

I think what your trying to tell me is I need to define the actual GUID? full string?
"CHARACTERGUID_Monkworks_BurningWitch000_93ddbfeb-f625-468a-bd4f-dd573ebca214"


"The easiest way to do this for a dynamically-created database (one that's added to when needed, rather than being declared in the INIT section) is to use a procedure, as this will set up the correct types with the compiler:"

I think you mean we can add a short word that will point to:
"CHARACTERGUID_Monkworks_BurningWitch000_93ddbfeb-f625-468a-bd4f-dd573ebca214"
, 1, "BurnWitch0" <<<

But were is the DB declaration for BurnWitch0? Like were is "BurnWitch0" stored?

Let me know if I am anywhere close to understanding the concept here, feel like I'm way off still.

The script complies now.


OK let me go and get a test area set up to see if we can get/see some working clean ups

Nothing to report. Test area set up. a few rats that I spawn and kill. I hit the Tigger and the corpse remain. I understand much more need to be built in here.